Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move ManualEditFile type from layout to props #114

Closed

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Move and camelcase manual edit types from @tscircuit/layout.

Link to Devin run: https://app.devin.ai/sessions/33b111c253d241538d7a310749545a94

Changes:

  • Moved ManualEditFile and related types from @tscircuit/layout
  • Added proper Zod schemas for type validation
  • Updated board and group components to use local ManualEditFile type
  • Temporarily using any[] for edit_events (TODO: add @tscircuit/manual-edit-events dependency)
  • Added export for manualEdit types in index.ts

Testing:

  • Formatted with Biome
  • Types checked
  • Tests passed

Closes #71

- Added manualEdit.ts with ManualEditFile and related types
- Updated imports to use local ManualEditFile type
- Fixed type checking issues in board.ts, group.ts, and subcircuit.ts
- Temporarily using any[] for edit_events until @tscircuit/manual-edit-events is available
- Added export for manualEdit types in index.ts

Co-Authored-By: Severin Ibarluzea <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

@seveibar seveibar closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the specification for manualEdits into props and camelcasify it
2 participants