Really call getObjectInfo when determining updated status of FeedFeed…

…erItems
tud-mit-plone · Sep 5, 2016 · b4521ae · b4521ae
1 parent 9c5bcbe
commit b4521ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -5,7 +5,9 @@ History of feedfeeder
 3.0.1 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Bug fix: really call getObjectInfo() when checking if an entry was updated.
+  This avoids unnecessary updates to FeedFeederItems
+  [tiberiuichim]
 
 
 3.0.0 (2016-02-22)

diff --git a/Products/feedfeeder/utilities.py b/Products/feedfeeder/utilities.py
@@ -165,7 +165,7 @@ def _retrieveSingleFeed(self, feedContainer, url):
                 # Not new, not refreshed: let it be, laddy.  Still,
                 # the entry might have changed slightly, so we check
                 # this.
-                if prev.getObjectInfo != entry:
+                if prev.getObjectInfo() != entry:
                     # Note: no need for a reindexObject here, which
                     # would also update the modification date, which
                     # we do not want.  See