Add timezones and pronouns #574
Merged
+172
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked until element-hq/synapse#17488 is merged, and conduwuit correctly returns JSON for custom keys other than the timezone one. Ideally, other server implementations will have added MSC4133 functionality by this time too. |
tulir
reviewed
Dec 30, 2024
| const pronouns: PronounSet[] = ensureArray(profile["io.fsky.nyx.pronouns"]) as PronounSet[] | ||
| return ( | ||
| <> | ||
| <hr/> |
There was a problem hiding this comment.
If there's no extended profile info, this results in there just being a random rule below the mxid that looks quite unsightly
since this function checks beforehand if there's anything to render, returning null if not, the hr isn't rendered in that case. Is there a better way about going about that without calculating whether anything would be shown in UserInfo?
There was a problem hiding this comment.
oh right I didn't notice the second condition 🤔
tulir
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #569
Adds timezones and pronouns support from MSC4133.
example:
