Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Madeline Mauser and Michael Marchand #186

Open
wants to merge 129 commits into
base: main
Choose a base branch
from
Open

Madeline Mauser and Michael Marchand #186

wants to merge 129 commits into from

Conversation

MarchandMD
Copy link

Here's our submission for the project.

I'd appreciate feedback on the poro/movie_search and how that would be converted to a facade and/or feedback RE additional happy/sad path testing that could be done for the Movies_controller

I would like to hear about the parties controller and how the create action was handled.

MarchandMD and others added 30 commits November 28, 2022 19:18
@MarchandMD
Configures rspec and adds Shoulda Matchers
a42a05c
@MarchandMD
Ignores simplecov output
8ed5882
@MarchandMD
Adds and tests models; setups up schema
db8c6eb
@MarchandMD
Adds bootstrap
6cf6c8a
@MarchandMD
Tests validations for user
81d2b23
@MarchandMD
Removes certain files from SimpleCov test monitoring
6d170ff
@MarchandMD
Adds views for index and partials for navbar
5188b6a
@MarchandMD
Adds route for root path
3c42c7f
@MarchandMD
Adds additional files from scaffolding of welcome controller
492fe20
@MarchandMD
Co-authored-by: Madeline Mauser <[email protected]…
915e65e 
…ly.github.com>

Tests Welcome#index
Landing Page Ticket

- [x] I have performed a self-review of my code
- [x] If it is a core feature, I have added thorough tests.
- [x] Will this be part of a product update? If yes, please write one phrase about this update.

Added a landing page which is tested and adheres roughly to the wireframe suggestion; Can be re-factored to include
dynamic information with inclusion of API data, once service established
@MarchandMD
Co-authored-by: Madeline Mauser <[email protected]…
80799a1 
…ly.github.com>

Moves banner to partial
n/a

- [x] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.
@MadelineMauser
Merge pull request #2 from MarchandMD/feat/landing_page
85cb403 
Feat/landing page
@MarchandMD @MadelineMauser
Updates .gitignore
ee33feb 
n/a

- [x] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Updates routes
ce43e6f 
- [ ] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Adds Users controller, begins testing
b83c787 
- [ ] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Adds Faker Gem for testing and seed data
a0020c3 
- [ ] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Adds seed data
29d506a 
- [ ] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Begins to develop Users Model, controller and views
1e94683 
- [x] I have performed a self-review of my code
- [x] If it is a core feature, I have added thorough tests.
- [x] Will this be part of a product update? If yes, please write one phrase about this update.

Begins to develop the Users portion of the app, preparing for integration with API.

Tests at 100% upon PR

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Applies partial for users index and welcome index
fbb5f86 
- [x] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MadelineMauser
Merge pull request #3 from MarchandMD/feat/users_controller_index_and…
472baab 
…_show

Feat/users controller index and show
@MarchandMD @MadelineMauser
Adds discover resource and corrects navbar link
93c9803 
- [x] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MadelineMauser
Add user list heading to welcome index
d15176b
@MarchandMD @MadelineMauser
Tests link for discover movies on user dashboard
823f3ad 
- [ ] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Adds Discover controller and view
a12a5ad 
- [x] I have performed a self-review of my code
- [x] If it is a core feature, I have added thorough tests.
- [x] Will this be part of a product update? If yes, please write one phrase about this update.

Preps app for inclusion of movie discovery

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD
Merge branch 'main' of github.com:MarchandMD/viewing_party_lite into …
82043c6 
…feat/discover_movies
@MarchandMD @MadelineMauser
Tests and adds features to the discover page
29b740c 
- [x] I have performed a self-review of my code
- [x] If it is a core feature, I have added thorough tests.
- [x] Will this be part of a product update? If yes, please write one phrase about this update.

Setting up template to receive information from API

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Adds Movies resources to routes and controllers
f12e7f4 
- [x] I have performed a self-review of my code
- [x] If it is a core feature, I have added thorough tests.
- [x] Will this be part of a product update? If yes, please write one phrase about this update.

movies resource, controller, and views added in preparation for API data

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Tests features for discover#index to link to movies
d330777 
- [ ] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MarchandMD @MadelineMauser
Redirects links from discover to movies; pending testing
7399613 
- [x] I have performed a self-review of my code
- [ ] If it is a core feature, I have added thorough tests.
- [x] Will this be part of a product update? If yes, please write one phrase about this update.

Tests are pending as AR/SQL/API calls are required to make this feature
100% functional

Co-authored-by: Madeline Mauser <[email protected]>
@MadelineMauser
Add tests for register page
ae7e02d
MadelineMauser and others added 30 commits December 2, 2022 11:06
@MadelineMauser
Remove unnecessary methods from party
3e0c9f9
@MadelineMauser
Add test for .other_users to user spec
aae0520
@MadelineMauser
Add .other_users to user
88682a0
@MarchandMD
Refactors to use Faraday
ac8db65
@MarchandMD
Stops tracking all fixtures
7308c5d
@MarchandMD
Hotfix for users#create
7e47744
@MadelineMauser
Add new party form
a686679
@MadelineMauser
Complete new party form functionality
b092521
@MadelineMauser
Merge pull request #16 from MarchandMD/hotfix/users_create
74badaa 
Hotfix/users create
@MadelineMauser
Merge main branch into current branch
a4eed5e
@MadelineMauser
Fix button path in movie show page
9f2e66d
@MadelineMauser
Change minor formatting
f480444
@MadelineMauser
Fix typo in path
e690f06
@MarchandMD
Merge pull request #17 from MarchandMD/feat/new-viewing-party
c986c0d 
Feat/new viewing party
@MarchandMD @MadelineMauser
Fixes redirect link; applies rubocop linting
20e498f 
- [x] I have performed a self-review of my code
- [x] If it is a core feature, I have added thorough tests.
- [n/a] Will this be part of a product update? If yes, please write one phrase about this update.

Co-authored-by: Madeline Mauser <[email protected]>
@MadelineMauser
Merge pull request #18 from MarchandMD/hotfix/testing_parties
ef4f3dc 
Fixes redirect link; applies rubocop linting
@MarchandMD
Updates gitignore
f74851d
@MarchandMD
adds basic authentication for user; renovates user_spec
5aae7da
@MarchandMD
Updates test files to use factories for user
f6ac20a
@MarchandMD
Updates schema and controllers and views to implement authentication
0d89315
@MarchandMD
Applies authentication
b459c03
@MarchandMD
Merge pull request #19 from MarchandMD/feat/basic_auth
5db0394 
Feat/basic auth
@MarchandMD
Adds rubocop gem
ba3c86c
@MarchandMD
Merge pull request #20 from MarchandMD/hotfix/rubocop
cb4c506 
Adds rubocop gem
@MarchandMD
Update README.md
6c4ce9d
@MarchandMD
Update README.md
01aa448
@MarchandMD
Update README.md
d2b2437
@MarchandMD
Updates readme
71c39bd
@MarchandMD
fixes merge conflicts
6250a70
@MarchandMD
Merge pull request #21 from MarchandMD/reno/readme
669b5f4 
Reno/readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarchandMD @MadelineMauser