CET-468/feat: Updated logic for displaying order intent response #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtkwr
reviewed
Oct 9, 2024
| @@ -380,6 +373,18 @@ define([ | |||
| contentType: 'application/json', | |||
| headers: {}, | |||
| data: JSON.stringify(orderIntentRequestBody) | |||
| }) | |||
| .done((response) => { | |||
|
With this PR, lets create some screenshots and check with the product/design team if the proposed behaviour is desirable. |
brtkwr
reviewed
Oct 10, 2024
| .done((response) => { | ||
| this.orderIntentResponse(response); | ||
| if (response.approved) { | ||
| this.orderIntentMessage(config.orderIntentApprovedMessage); |
There was a problem hiding this comment.
Where are we displaying the orderIntentMessage?
brtkwr
reviewed
Oct 10, 2024
| self.processOrderIntentSuccessResponse(response); | ||
| }) | ||
| .fail(function (response) { | ||
| self.processOrderIntentErrorResponse(response); |
There was a problem hiding this comment.
Does this mean we can remove processOrderIntentErrorResponse function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Logic for order intent response