Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to set emptyDir sizeLimit #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pkrzaczkowski-hippo
Copy link

This PR allows setting ephemeral storage sizeLimit.

Right now if no PVC storage is defined, an emptyDir volume is created without any size limits. This can cause the storage of the node to run out.

This PR adds an option to limit ephemeral storage the same way as we limit PVC claim storage.

https://kubernetes.io/docs/concepts/storage/volumes/#emptydir

Default value is set to "0" - which is unlimited

@pkrzaczkowski-hippo
Copy link
Author

@canterberry

Copy link
Member

@canterberry canterberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor quibble, emptydir should be emptyDir, else it's a typo-in-waiting for someone. Non-blocking, though. Approved.

@canterberry
Copy link
Member

Thank you!

@vyas-n
Copy link
Collaborator

vyas-n commented Mar 5, 2024

Hi @canterberry,

Do you still want signed commits to be a requirement for contributions moving forward?

For example, this PR could be merged without the requirement.

@vyas-n
Copy link
Collaborator

vyas-n commented Mar 5, 2024

Alternatively @pkrzaczkowski-hippo,

Would you be able to sign your commits using a GPG key and push it up to this branch?

There's a guide on GitHub on how to sign commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

As well as this guide for how to sign and push up previous commits: https://stackoverflow.com/a/15667644/8401320

Once you've resigned your commit, you can push it up with a git push -f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants