fix(network): correct PoolDistr and update ProtocolParam #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarmuega
reviewed
Dec 12, 2024
|
I believe so, because the encoding of the fraction at `GenesisConfig` is
not the same (!). So it seems two different types are needed.
|
Signed-off-by: Pedro Sánchez Terraf <[email protected]>
scarmuega
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A field of the
Poolstruct (corresponding to the node'sPoolDistr) was a naively encoded rational numberFraction; this one is indeed needed in the genesis config struct, which I renamed fromGenesisto the more explicitGenesisConfig.In the case of
ProtocolParam, theProtocolVersionis now a tuple(major, minor).Both corrections have an impact on the
examples/n2c-miniprotocolsfolder; two broken examples there now run smoothly. In that folder, I moved the initialPointof the block-fetching performed bydo_chainsyncto a more recent moment in order to be able to witness the reaching of the chain tip.This solves #496.