feat(codec): allow KeepRaw to own its data #601
Merged
+28
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
KeepRaw
store the original data as aCow<'b, [u8]>
instead of a&'b [u8]
, and add ato_owned
method. Justification for this change is in #599, but tl;dr it lets you avoid awkward lifetime problems.This is a breaking change, the
raw_cbor()
method now returns a&[u8]
instead of a&'b [u8]
. In practice, this means that a reference to the raw bytes can no longer outlive a reference to the structure itself.Also adds an
as_ref
method to theNullable<T>
helper, to fix a lifetime problem this changed introduced.