Allow search and multi-search to return raw data #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overriden 2 function:
Documents.search()
MultiSearch.perform()
Why make this change
Currently the above 2 function will take a Codable type
T
and then try to decode it immediately after retrieving the data. This is not ideal because we lose the opportunities to implement a custom data parsing logic to it. E.g.Documents.search()
: This function uses the default JSON decoder to decode the data. But sometimes we want to use other decoders, such as Firestore Decoder.MultiSearch.perform()
: This function only takes 1 type of Codable, which is not ideal. E.g. for a social media app, when searching a post, we want to have some search suggestions. They are different types of data and the function won't be able to decode the multi search result.PR Checklist