Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce hashids_init4 to allow client to specify custom separators #30

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

okft
Copy link

@okft okft commented Jun 13, 2020

It lets me using vowels as separators which is a better way to avoid slang words in French for intance.

@okft
Copy link
Author

okft commented Jun 24, 2020

As requested, I updated the test suite (and found an error in my code), and the README file.
I amended my first commit but when doing the rebase it seems git made another commit in-between.

Note that the last 4 tests are kind of broken with my custom separator set.

    {"", 1337, HASHIDS_DEFAULT_ALPHABET,
        "aeiouy",
        1, {1337ull},
        "...", __LINE__},

triggers a buffer overflow on my side

and

    {"", 22, "abdegjk0123456789",
        "aeiouy",
        1, {190126ull}, "070683k2j3771430j49157", __LINE__},
    {"\\7ULC'", 22, "@'l*p9n]);+7>Ar(\\",
        "aeiouy",
        1, {190126ull}, "9];r(An97\\]]\\()>7>\\)+]", __LINE__},

have the same result using HASHIDS_DEFAULT_SEPARATORS or my custom separators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant