Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated score module to handle duplicate left-hand duplicate terms #54

Conversation

clpetersonucf
Copy link
Member

@clpetersonucf clpetersonucf commented Aug 22, 2024

Resolves #53

  • Moves string comparison prep into an instance function
  • For every log item, the question text (left side of pair) is compared against all other questions for duplicates. Answer text matches associated with duplicates are also considered valid, and are added to an array of possible answers. The log's answer text is now compared against all possible answers for a given log, which should now accommodate duplicate answer text (via $givenAnswer) and duplicate question text (via matches with $possibleAnswers).

Last second, unrelated fix:

  • Adds validation to question bank value on save to ensure it's not set higher than the current word pair count.

@dmols dmols self-requested a review August 22, 2024 19:14
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as intended!

@clpetersonucf clpetersonucf merged commit 63e41ff into ucfopen:master Aug 22, 2024
1 check passed
@clpetersonucf clpetersonucf deleted the issue/53-duplicate-questions-matching-left-side branch August 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate matches will not be scored correctly when duplicates are on the left side
2 participants