#6 Disables viewing other recorded responses at scorescreen by default. Adds UI to optionally enable it. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly addresses issue #6 adding a toggle button in the creator(disabled by default) to enable the viewing the viewing of other recorded responses at the scorescreen.
This PR has some changes to the creator HTML and SCSS with the use of flex-box and modern web practices, but it does not fix everything existing in the widget. There are still some old outdated HTML4 tags like center which may need to be addressed to fix tool-tips going out of bounds. Additionally it would be easier to make more additions to the front-end if it was redesigned with better practices like flex-box and div nesting instead of absolute positioning for a lot of things, but that feels more appropriate for a separate issue.
This PR adds an options object to the qset which stores a boolean value on whether or not to get feedback of all other recorded responses. It does not break existing widgets that do not have this options object in my testing.