Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the navbar overhaul #168

Merged
merged 6 commits into from
Apr 23, 2024
Merged

the navbar overhaul #168

merged 6 commits into from
Apr 23, 2024

Conversation

AVDestroyer
Copy link
Contributor

@AVDestroyer AVDestroyer commented Apr 22, 2024 •
edited by Arc-blroth
Loading

do we wanna make the navbar buttons narrower or nah?
closes #160
closes #111

@AVDestroyer AVDestroyer linked an issue Apr 22, 2024 that may be closed by this pull request
Add [Platform] button to website #160
Closed
@Arc-blroth
Copy link
Member

Arc-blroth commented Apr 23, 2024 •
edited
Loading

is it time to make multilevel menu headers 💀

About
+ Who We Are
+ Members

Events
+ Upcoming
+ Archive
+ Google Calendar

Blog
+ The CyBlog
+ PBR Blog

Links
+ Discord
+ Platform
+ PBR
+ LA CTF
+ Status

[ Join Us ]

@Arc-blroth Arc-blroth changed the title added platform link to navbar the navbar overhaul Apr 23, 2024
@Arc-blroth
Copy link
Member

also (going to) close #111

@Arc-blroth Arc-blroth self-assigned this Apr 23, 2024
@Arc-blroth Arc-blroth requested review from bliutech and removed request for bliutech April 23, 2024 09:55
@bliutech bliutech self-requested a review April 23, 2024 16:24
bliutech
bliutech approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I thought the addition of the Links tab seems a bit odd. I'm not sure if Status needs to be a public facing link.

Tested on MacOS Chrome, Safari, and iOS.

@AVDestroyer
Copy link
Contributor Author

On firefox on windows, it has a scroll bar on the bottom.

I do remember this happening to me in 35l and I think the fix was to make the width 99vw instead of 100vw if that's related to this at all.

image

@AVDestroyer
Copy link
Contributor Author

this happens on all my browsers, but only on the landing page

@AVDestroyer AVDestroyer merged commit d279231 into main Apr 23, 2024
@Arc-blroth Arc-blroth mentioned this pull request Apr 24, 2024
Closed
@AVDestroyer AVDestroyer deleted the navbar branch April 24, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bliutech bliutech bliutech approved these changes

Assignees

@Arc-blroth Arc-blroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add [Platform] button to website Bug: Navbar UI Overlap
3 participants
@AVDestroyer @Arc-blroth @bliutech