README.rst: Add installation steps using venv #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayan-b
reviewed
Mar 31, 2019
There was a problem hiding this comment.
In general, it is a good practice to keep the virtualenv outside root, i.e.:
some_directory
|- env
|- xena-GDC-ETL
Also, the user may want to use some other name than gdc-venv, so you may want to remove that from .gitignore and this won't work for Windows so you may want to add that process as well.
|
Oh yes, thanks for the suggestions! |
README: Installing using venv
roshnet
force-pushed
the
install_steps_venv
branch
from
4c249df to
e18e8ad
Compare
|
@roshnet needs a rebase in order to pass the tests. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.