New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: mark rpc function as blocking #23

Closed

mattsse wants to merge 1 commit into ultrasoundmoney:main from mattsse:matt/make-request-blocking

Contributor

mattsse commented Dec 15, 2023

The implementation of this endpoint is blocking and does not require async.

This PR makes it non-async and marks it as blocking. The server will then spawn this function on a task that is allowed to block.


          perf: mark rpc function as blocking

c8d2fea

Contributor Author

mattsse commented Dec 15, 2023

closing because this will conflict with improvement ideas I have

mattsse closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet