PR Week 6 #33
Open
PR Week 6 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablo-alex
reviewed
Jun 9, 2023
Comment on lines
+14
to
+16
| data.sort(sortByDate).map((cardData) => | ||
| <Card key={cardData.date} data={cardData} /> | ||
| ) |
There was a problem hiding this comment.
Suggested change
| data.sort(sortByDate).map((cardData) => | |
| <Card key={cardData.date} data={cardData} /> | |
| ) | |
| data.sort(sortByDate).map((cardData, index) => | |
| <Card key={index} data={cardData} /> | |
| ) |
No creo que sea buena idea usar la fecha como key para la card, puede que haya entradas que tengan el mismo dia, mejor lo veo usar el index
pablo-alex
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Hola @EzequielCaste todo esta correcto, veo que el responsive esta funcionando y todo esta de acuerdo a los requerimientos, deje un pequeño comentario pero ya esta probado. Si me puedes dar una mano con mi PR semana 6 te lo agradeceria
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Student Blog built with React using Vite.