Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record missing when record count greater than 20 #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EkkoG
Copy link

@EkkoG EkkoG commented Jul 16, 2021

According to the doc https://api.cloudflare.com/#dns-records-for-a-zone-list-dns-records

API only returns 1 page, and 20 records per page, so when record count greater than 20, some record will missing in local cache, then RecordNotFound occur. This patch changes the page size to 100, the max page size, to avoid the issue.

Copy link
Owner

@undefinedplayer undefinedplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It'll be great to expose per_page as an parameter upstream to the main function and set it default to 100? In that case it would support the case if it has more than 100 records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants