Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[US-639] Linter related updates #62

Merged
merged 6 commits into from
Sep 20, 2024
Merged

[US-639] Linter related updates #62

merged 6 commits into from
Sep 20, 2024

Conversation

3ace
Copy link
Contributor

@3ace 3ace commented Sep 20, 2024 •
edited
Loading

this also contains updates introduced by @sampila in #60

@3ace 3ace requested a review from sampila September 20, 2024 10:46
sampila
sampila approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sampila sampila mentioned this pull request Sep 20, 2024
Closed
@sampila sampila requested a review from gunnsth September 20, 2024 11:24
gunnsth
gunnsth approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 9dfe4f1 into unidoc:master Sep 20, 2024
6 checks passed
@3ace 3ace deleted the us-639-linter-updates branch September 22, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampila sampila sampila approved these changes

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3ace @gunnsth @sampila