Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cache dataframe config args, fix tests #1437

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

cosmicBboy
Copy link
Collaborator

This PR renames the pandera config arguments introduced in this PR: #1414 and makes the names more generic. Fixes tests that were broken by the config changes.

This PR renames the pandera config arguments introduced in this PR:
#1414 and makes the names
more generic. Fixes tests that were broken by the config changes.

Signed-off-by: Niels Bantilan <[email protected]>
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a318e48) 94.27% compared to head (65c55cc) 94.28%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1437   +/-   ##
=======================================
  Coverage   94.27%   94.28%           
=======================================
  Files          91       91           
  Lines        7007     7013    +6     
=======================================
+ Hits         6606     6612    +6     
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmicBboy cosmicBboy merged commit 7a20c7a into main Dec 5, 2023
55 checks passed
@cosmicBboy cosmicBboy deleted the fix-unit-test branch December 6, 2023 21:11
max-raphael pushed a commit to max-raphael/pandera that referenced this pull request Jan 24, 2025
This PR renames the pandera config arguments introduced in this PR:
unionai-oss#1414 and makes the names
more generic. Fixes tests that were broken by the config changes.

Signed-off-by: Niels Bantilan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant