-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/1463 Pandas 2.2.0 FutureWarning resolution by using assignment instead of … #1464
Conversation
…inplace Signed-off-by: Derin Walters <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1464 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 91 91
Lines 7024 7024
=======================================
Hits 6623 6623
Misses 401 401 ☔ View full report in Codecov by Sentry. |
@cosmicBboy Do you have any knowledge of the two issues with master branch that I mentioned above? Looks like all pull requests from the past three weeks are running into the same linter issue at least. |
@derinwalters lemme check |
@derinwalters do you mind rebasing on |
@cosmicBboy green means go. Thanks for the assist! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @derinwalters! 🚀
…inplace (unionai-oss#1464) Signed-off-by: Derin Walters <[email protected]>
From #1463
Minor update to replace inplace fillna of default values with an assignment, as per FutureWarning from Pandas 2.2.0.
Please note I encountered the two issues below that existed on the master branch prior to any edits. Otherwise, all is clean.