Implement minimal built-in checks for Ibis backend #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ibis-dev #1885 +/- ##
============================================
+ Coverage 92.76% 92.91% +0.14%
============================================
Files 133 134 +1
Lines 9705 9722 +17
============================================
+ Hits 9003 9033 +30
+ Misses 702 689 -13 ☔ View full report in Codecov by Sentry. |
deepyaman
force-pushed
the
feat/ibis/builtin-checks
branch
2 times, most recently
from
3d0efc6 to
da8490f
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
deepyaman
force-pushed
the
feat/ibis/builtin-checks
branch
from
da8490f to
5744a4c
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base should be the updated
ibis-devfrom #1884This is still a work in progress, as it seems I will need to implement validation of
ir.Columnobjects