Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added several bills #12

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

morphogencc
Copy link

Added:
-stop militarizing law enforcement act
-USA Freedom Act / End Bulk Collection Act
-Keystone XL Act

Eavesdropping, Dragnet-collection and Online Monitoring Act" meant to halt mass data collection by the NSA and FBI.
Failed in Nov 2014.
hr,3361,113,End Bulk Collection Act,See "USA Freeedom Act"
s,2685,113,The senate version of hr.3361 (USA Freedom Act / End Bulk Collection Act)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this line is missing the name field?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops; you're right! fixing it right now and resending.

nathan

On Sun, Jan 25, 2015, at 08:21 PM, Eric Mill wrote:

@@ -32,3 +32,12 @@ hr,519,113,uafa,Uniting American Families Act of 2013
s,296,113,uafa,Uniting American Families Act of 2013
hr,717,113,uafa,Reuniting Families Act
hr,83,113,cromnibus,Nickname for the Consolidated and Further Continuing Appropriations Act of 2015
+hr,5478,113,Stop Militarizing Law Enforcement Act,amends the program that allows DoD to transfer weapons and gear to
+federal and state agencies for law enforcement activities.
+hr,3361,113,USA Freedom Act, Acronym for "Uniting and Strengthening America by Fulfilling Rights and Ending
+Eavesdropping, Dragnet-collection and Online Monitoring Act" meant to halt mass data collection by the NSA and FBI.
+Failed in Nov 2014.
+hr,3361,113,End Bulk Collection Act,See "USA Freeedom Act"
+s,2685,113,The senate version of hr.3361 (USA Freedom Act / End Bulk Collection Act)

Looks like this line is missing the name field?


Reply to this email directly or view it on GitHub:
https://github.com/unitedstates/bill-nicknames/pull/12/files#r23509824

@morphogencc
Copy link
Author

Fixed the requested issues, added two more bills.

@plantfansam
Copy link
Contributor

This is kind of a bummer, but I ran into a few format errors with the csv running it through csvlint. There were some issues where the bill descriptions contained commas.

Was able to get it mostly validating with some modifications modifications here.

@morphogencc
Copy link
Author

Oh my! Sorry about that; I thought I caught them, but I can go back in
and check. I'll investigate with csvlint and send another pull request.

sorry about that!

(also, you should mention csvlint in the README -- it's good to know
about!)

nathan

On Fri, Jan 30, 2015, at 03:58 PM, Sam wrote:

This is kind of a bummer, but I ran into a few format errors with the csv
running it through csvlint. There were some issues
where the bill descriptions contained commas.

Was able to get it mostly
validating
with
some modifications modifications
here.


Reply to this email directly or view it on GitHub:
#12 (comment)

nathan lachenmyer and others added 4 commits January 30, 2015 16:46
@morphogencc
Copy link
Author

should be all fixed!

thanks for your patience!

nathan

On Fri, Jan 30, 2015, at 04:30 PM, nathan.lachenmyer wrote:

Oh my! Sorry about that; I thought I caught them, but I can go back in
and check. I'll investigate with csvlint and send another pull request.

sorry about that!

(also, you should mention csvlint in the README -- it's good to know
about!)

nathan

On Fri, Jan 30, 2015, at 03:58 PM, Sam wrote:

This is kind of a bummer, but I ran into a few format errors with the csv
running it through csvlint. There were some issues
where the bill descriptions contained commas.

Was able to get it mostly
validating
with
some modifications modifications
here.


Reply to this email directly or view it on GitHub:
#12 (comment)

@konklone
Copy link
Member

Adding csvlint to the Travis build process for the repo seems like a good idea. I'll prepare a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants