Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates per #139 #143

Merged
merged 2 commits into from
Apr 1, 2017
Merged

Updates per #139 #143

merged 2 commits into from
Apr 1, 2017

Conversation

msimonborg
Copy link
Contributor

  • Change link values for new images to the context of the image, not the source

  • An edit to CONTRIBUTING.md to add this requirement for future contributions.

@hugovk
Copy link
Member

hugovk commented Apr 1, 2017

Thank you!

When adding link: to the script in #128 I noted the following, but it's not much use hidden away in a closed PR :)

When running, remember to check the URL is the one we want. For example, usually we don't want a Wikimedia URL but a link to the office of the senator (see #125 / #127).

Similarly, in hugovk@930017f#diff-220a71791f0b8551fb315470034e2fd7R2 we don't want a GitHub URL like https://cloud.githubusercontent.com/assets/3171982/7505422/46c2791e-f420-11e4-9360-0bb6ff136a04.jpg but instead want "Not available" as it was sent by email from their office.

@hugovk hugovk merged commit 870db54 into unitedstates:gh-pages Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants