Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow building Samples App WinUI for .NET 9 #18982

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: Allow building Samples App WinUI for .NET 9 #18982

wants to merge 7 commits into from
+9 −3

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Only .NET 8 is supported

What is the new behavior?

Both 8 and 9 are supported

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@MartinZikmund MartinZikmund self-assigned this Dec 2, 2024
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Dec 2, 2024
@MartinZikmund MartinZikmund force-pushed the dev/mazi/net9-windows-samplesapp branch from 1996bfd to 1c1aa4a Compare December 2, 2024 15:34
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149099 has failed on Uno.UI - CI.

@jeromelaban
Copy link
Member

/azp run

@jeromelaban jeromelaban enabled auto-merge December 4, 2024 21:28
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149410 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/net9-windows-samplesapp branch from 1c1aa4a to 2e99d0f Compare December 5, 2024 10:31
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149470 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/net9-windows-samplesapp branch from 79d248b to db73e5a Compare December 8, 2024 16:43
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18982/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/net9-windows-samplesapp branch from db73e5a to d30de98 Compare December 20, 2024 17:37
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 150687 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/net9-windows-samplesapp branch from d30de98 to 49f3e9f Compare January 8, 2025 11:21
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18982/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/net9-windows-samplesapp branch from 98d96d0 to 0432415 Compare January 8, 2025 12:51
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18982/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 151315 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/net9-windows-samplesapp branch from c979bda to a874575 Compare January 9, 2025 11:57
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18982/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@ajpinedam ajpinedam ajpinedam approved these changes

Assignees

@MartinZikmund MartinZikmund

Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinZikmund @unodevops @jeromelaban @ajpinedam