Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2074: USAGOV-2074 - element doesnt meet min size #2115

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

DaleMHFrey
Copy link
Contributor

Interactive element does not meet minimum size nor spacing

https://cm-jira.usa.gov/browse/USAGOV-2074

Description

Injected a styling oneoff that increases the font size of the phone-number so that the height of the text is at least 24 pixels in height, in order to meet the accessibility requirements.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Open your browser, inspect the phone number in the footer of any page. When you hover over the phone-number element in the inspector (in Chrome), it shows you the rendered height of the element. The height is supposed to be 24 pixels minimum.

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@akf akf requested a review from cwacht December 17, 2024 00:47
@akf
Copy link
Member

akf commented Dec 17, 2024

I can see that the font is bigger, but I'd like @cwacht to review the approach (since he's consolidating font sizes now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants