usagov-2120-page-region-attribute: update logic to remove role attrib…

[developer43]

…ute if no image is chosen

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2120

Description

Update code logic to remove role=“region” and area-label for alert box with no image or title

Type of Changes

• New Feature
• Bugfix
• Frontend (Twig, Sass, JS)
  • Add screenshot showing what it should look like
• Drupal Config (requires "drush cim")
• New Modules (requires rebuild)
• Documentation
• Infrastructure
  • CMS
  • WAF
  • WWW
  • Egress
  • Tools
  • Cron
• Other

Testing Instructions

Change Requirements

• Requires New Documentation (Link: {})
• Requires New Config
• Requires New Content

Validation Steps

• Goto http://localhost/voter-registration-card and inspect the info alert box to verify that the code contains role="region"
  and aria-label="info". This alert box should contain an image and a title.

• Goto https://www.usa.gov/adjustment-of-status and inspect the alert box with the gray left bar in the content area to verify that the code does not contain role="region" and aria-label="info". This alert box should contain no image or title.

• Verify the same steps on the Spanish pages below.
• http://localhost/es/solicitar-tarjeta-registro-electoral

• http://localhost/es/ano-nuevo

Security Review

• Adds/updates software (including a library or Drupal module)
• Communication with external service
• Changes permissions or workflow
• Requires SSPP updates

Reviewer Reminders

• Reviewed code changes
• Reviewed functionality
• Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

1. Go to the USAGov Circle CI project.
2. Find the commit of this pull request.
3. Build and deploy the changes.
4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

[akf]

This is all good, but I think we need the aria-labels to be in Spanish when the page is in Spanish.

Right now, this uses the same text in the aria-label as in the alert class. We probably need a little table of translations as well.