Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2016-v3: USAGOV-2016 nginx redirects #2151

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

DaleMHFrey
Copy link
Contributor

https://cm-jira.usa.gov/browse/USAGOV-2016

Description

Adding in nginx redirects rule

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

  • Going to a URL of /foo/bar should load a not-found page, which is fine
  • but after merging this, going to /foo/bar%C2%A0 should redirect you to /foo/bar
  • and so should /foo/bar%E2%80%89 and /foo/bar%E2%80%83
  • mainly I want to make sure that this configuration is now crashing the WWW nginx container on Dev since this is kind of a blind edit there as I dont quite know how to run the WWW container on my local

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@YaritzaGarcia YaritzaGarcia self-requested a review January 7, 2025 13:42
@YaritzaGarcia YaritzaGarcia merged commit 6b77625 into dev Jan 7, 2025
4 of 5 checks passed
@YaritzaGarcia YaritzaGarcia deleted the USAGOV-2016-v3 branch January 7, 2025 17:59
@DaleMHFrey
Copy link
Contributor Author

I am closing this PR as I have come to realize that (1) the code-change here does not work, and (2) I have a new PR that reverts this code and fixes the issue, at: #2156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants