fix flag parsing bug

utilitywarehouse · Dec 27, 2024 · 1570a3c · 1570a3c
1 parent 949dd1b
commit 1570a3c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -15,7 +15,7 @@ env:
   IMAGE_NAME: ${{ github.repository }}
 
 jobs:
-  docker:
+  build:
     runs-on: ubuntu-latest
     if: github.actor != 'dependabot[bot]'
     steps:

diff --git a/Dockerfile b/Dockerfile
@@ -14,8 +14,7 @@ RUN go mod download
 # Copy the go source
 COPY . .
 
-RUN \
- go test -v -cover ./... && \
+RUN go test -v -cover ./... && \
     CGO_ENABLED=0 go build -a -o metrics-aggregator
 
 FROM alpine:3.20

diff --git a/main.go b/main.go
@@ -197,8 +197,13 @@ func main() {
 	}
 
 	for _, pair := range strings.Split(*addLabels, ",") {
+		if pair == "" {
+			continue
+		}
 		kv := strings.Split(pair, "=")
-		collector.addLabels[kv[0]] = kv[1]
+		if len(kv) == 2 {
+			collector.addLabels[kv[0]] = kv[1]
+		}
 	}
 
 	reg := prometheus.NewPedanticRegistry()
-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,7 @@ env: @@
       IMAGE_NAME: ${{ github.repository }}
     jobs:
-      docker:
+      build:
         runs-on: ubuntu-latest
         if: github.actor != 'dependabot[bot]'
         steps:
@@ Expand Down @@