Primary key permission #288
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fogelito What's the benefit of this change? Please add a description to the PR 🙏 |
|
We have a Benchmark for this on Asana |
|
@fogelito Awesome let's add a migration PR in Appwrite for this as well |
abnegate
approved these changes
Aug 7, 2023
|
Still need to make changes here as in the update for example we need to pass the internal id after read the original doc. |
|
@fogelito Cool will mark this as draft for now 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to changes in all _perms collection from using Varchar DocumentId => integer document id
For better performance and shrinking the index resources.
Since this is internal it would be relatively easier changes.