Primary key bigint #482
Open
Primary key bigint #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
reviewed
Nov 18, 2024
src/Database/Adapter/MariaDB.php
Outdated
| @@ -215,6 +215,7 @@ public function createCollection(string $name, array $attributes = [], array $in | |||
| } catch (PDOException $e) { | |||
| $e = $this->processException($e); | |||
|
|
|||
| // Can we remove drop perms table? | |||
There was a problem hiding this comment.
Please open these questions as comments on the PR or linear so we don't need code changes to remove them if there's no change to resolve 👍
For this case, why would we remove it? Wouldn't it result in leftover data?
There was a problem hiding this comment.
Sure will open comment comment next time 👍
Not sure if this can happen but , Trying to creat an existing collection will trigger a duplication exeption?
There was a problem hiding this comment.
I think this case will never actually happen unless you call createCollection directly on the adapter instead of Database, since database already does a duplicate check and throws the exception there 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.