Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sending of batch emails without exposing all recipient emails #90

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ChiragAgg5k
Copy link

@ChiragAgg5k ChiragAgg5k commented Jan 13, 2025

What does this PR do?

This PR addresses the data security concerns while sending of batch emails that exposes all the other recipients emails to every recipient.

Test Plan

setup:

Screenshot 2025-01-12 at 8 23 14 PM

mailgun working:

Screenshot 2025-01-12 at 8 22 56 PM

sendgrid working:

Screenshot 2025-01-14 at 1 19 18 PM

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes.

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about SMTP?

@ChiragAgg5k
Copy link
Author

ChiragAgg5k commented Jan 17, 2025

It will be done in a separate PR in appwrite repo... (working on it) Till then i think this should be good to merge.

created the PR- appwrite/appwrite#9243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants