-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create daily action to update adobe-activation #2417
Conversation
Hi, just a gentle reminder—when you have a moment, could you please review this PR? Thank you! |
I am traveling, sorry this PR will not be reviewed for the following week. |
|
||
- name: Download pihole.txt | ||
run: | | ||
curl -sSL https://raw.githubusercontent.com/ignaciocastro/a-dove-is-dumb/main/pihole.txt -o new-pihole.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the time I checked this source, it was updated within 24hrs, which is good.
But I am not sure this source will get long enough maintenance, that is a NO-GO to me to use a third-party source.
BTW, you have to make sure that we will not violate their open-source license. You might just forget to mention it in this PR.
ic.adobe.io | ||
cc-api-data.adobe.io | ||
0mo5a70cqa.adobe.io | ||
1b9khekel6.adobe.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes no point in abusing the domain:
suffix, these domains should be matched with the full:
suffix.
You are suggested to maintain a fork of this project. I would appreciate it if you could see my point. |
Thank you for the feedback. I understand your concerns and will close this PR. |
Closes: #2394
This pull request introduces a new GitHub Actions workflow to automate the update of the Adobe Activation list. The workflow is scheduled to run daily and includes steps to check for changes and update the list if necessary.