Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP status code to HttpResponseError #116

Merged

Conversation

tomerm-iguazio
Copy link
Contributor

Part of ML-5598.

@tomerm-iguazio tomerm-iguazio force-pushed the add_status_to_HttpResponseError branch from c1ef5c1 to 88e734a Compare February 12, 2024 11:47
@gtopper gtopper changed the title [Object] add status to error. Add HTTP status code to HttpResponseError Feb 12, 2024
v3io/dataplane/response.py Outdated Show resolved Hide resolved
Copy link
Member

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise 👍

tests/test_client_errors.py Outdated Show resolved Hide resolved
tests/test_client_errors.py Outdated Show resolved Hide resolved
Copy link
Member

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@assaf758 assaf758 merged commit 64d4799 into v3io:development Feb 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants