handle clicks outside inventory and non modifying clicks #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes some re-syncs because the validation did not accept the now specific cases (all of the affected modifications where cases where the user did not modify the inventory)
Cases like:
This causes unneccery re-syncs to the client and also unneccery logs indicating some illegal client packets, while these packets are totaly fine
Solution
adjusted packet validation logic to allow these cases, but also check for "conservation of mass" when these special magic slot ids shows up
modified the handling code to basically ignore these changes, (I guess there is room for improvement here, as some event would probably be nice to publish in these cases?)