Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): fix test and cover new sign method #99

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

jeanregisser
Copy link
Member

Follow up from: #98

Since secrets aren't shared with external PRs, I manually tested locally but missed running the e2e test itself.
And then it failed once merged into main: https://github.com/valora-inc/viem-account-hsm-gcp/actions/runs/13139225860/job/36661999051

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (bdf263a) to head (3b4840d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   93.33%   93.65%   +0.31%     
==========================================
  Files           2        2              
  Lines          60       63       +3     
  Branches        6        6              
==========================================
+ Hits           56       59       +3     
  Misses          4        4              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a732f...3b4840d. Read the comment docs.

@jeanregisser jeanregisser merged commit 2c6f8f9 into main Feb 4, 2025
6 checks passed
@jeanregisser jeanregisser deleted the jeanregisser/fix-e2e branch February 4, 2025 17:54
Copy link

github-actions bot commented Feb 4, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants