Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Owner Ethereum Address Configuration into Hello World ABCI #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PriyanshuVijay-S
Copy link

Overview

This pull request introduces a new configuration parameter for the Hello World ABCI service, aiming to enhance traceability by including the owner's Ethereum address in output messages. This feature allows better monitoring and identification of operations across different deployment environments.

Changes in Hello World ABCI

  • Added Owner Address Parameter:

    • Introduced a new configuration parameter owner in the HelloWorldParams class in models.py.
    • Configured the owner parameter in service.yaml, aea-config.yaml, and skill.yaml to support dynamic setup via environment variables or direct configuration.
  • Enhanced Behaviour:

    • Modified the PrintMessageBehaviour in behaviours.py to include the owner's Ethereum address in the "Hello World" message.
    • Example output: "Hello World! The owner’s address is 0xEE93B2F35C8Ef5Bf0395286Ea887181970916243"

File Changes:

  • service.yaml:

    • Added environment variable placeholders (HELLO_WORLD_OWNER_1, HELLO_WORLD_OWNER_2, etc.) for agent-specific owner addresses.
  • aea-config.yaml:

    • Integrated default values for the owner address in the agent-level configuration.
  • skill.yaml:

    • Added the owner address parameter under the params section.
  • behaviours.py:

    • Accessed the owner address from the shared state and included it in the output message.
  • models.py:

    • Added theowner address parameter to the HelloWorldParams class.

Technical Details:

  • Introduced a owner: str address parameter in HelloWorldParams.
  • Updated the configuration to allow dynamic owner address assignment via environment variables.
  • Ensured compatibility with existing configurations and behavior.

Testing:

  • Built and tested locally using Docker.
  • Verified the owner address is correctly displayed in the agent outputs.
  • Confirmed configuration works across multiple agents.

How to Test:

  1. Clone the repository.
  2. Configure owner addresses in service.yaml, aea-config.yaml, and skill.yaml :
    export owner ="0xEE93B2F35C8Ef5Bf0395286Ea887181970916243"
    
  3. Run the deployment and verify the output. The "Hello World" message should include the owner’s Ethereum address.

cpp-priyanshu and others added 2 commits November 27, 2024 01:15
- Introduce a new configuration parameter for the owner's Ethereum address in the skill configuration.
- Implement access to this parameter through the shared state of the skill.
- Modify relevant output to include 'Hello world! The owner’s address is 0xEE93B2F35C8Ef5Bf0395286Ea887181970916243' where the actual address is dynamically retrieved.
- Ensures compatibility with existing configuration structures and error handling for missing configuration entries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant