fix: skip sets by name during import (#539)

variar · Nov 18, 2024 · bf78979 · bf78979
1 parent e34ea72
commit bf78979
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/src/ui/include/highlighterset.h b/src/ui/include/highlighterset.h
@@ -184,6 +184,7 @@ class HighlighterSetCollection final : public Persistable<HighlighterSetCollecti
     HighlighterSet currentActiveSet() const;
 
     bool hasSet( const QString& setId ) const;
+    bool hasSetByName( const QString& name ) const;
 
     QStringList activeSetIds() const;
     void activateSet( const QString& setId );

diff --git a/src/ui/src/highlightersdialog.cpp b/src/ui/src/highlightersdialog.cpp
@@ -211,15 +211,21 @@ void HighlightersDialog::importHighlighters()
         this, tr( "Select one or more files to open" ), "", tr( "Highlighters (*.conf)" ) );
 
     for ( const auto& file : files ) {
-        LOG_DEBUG << "Loading highlighters from " << file;
+        LOG_INFO << "Loading highlighters from " << file;
         QSettings settings{ file, QSettings::IniFormat };
         HighlighterSetCollection collection;
         collection.retrieveFromStorage( settings );
         for ( const auto& set : klogg::as_const( collection.highlighters_ ) ) {
-            if ( highlighterSetCollection_.hasSet( set.id() ) ) {
+            if ( highlighterSetCollection_.hasSet( set.id() )
+                 || highlighterSetCollection_.hasSetByName( set.name() ) ) {
+
+                LOG_INFO << "Skipping set " << set.name() << " (" << set.id() << ")";
+
                 continue;
             }
 
+            LOG_INFO << "Adding set " << set.name() << " (" << set.id() << ")";
+
             highlighterSetCollection_.highlighters_.append( set );
             highlighterListWidget->addItem( set.name() );
         }

diff --git a/src/ui/src/highlighterset.cpp b/src/ui/src/highlighterset.cpp
@@ -480,6 +480,12 @@ bool HighlighterSetCollection::hasSet( const QString& setId ) const
                         [ setId ]( const auto& s ) { return s.id() == setId; } );
 }
 
+bool HighlighterSetCollection::hasSetByName( const QString& setName ) const
+{
+    return std::any_of( highlighters_.begin(), highlighters_.end(),
+                        [ setName ]( const auto& s ) { return s.name() == setName; } );
+}
+
 QList<QuickHighlighter> HighlighterSetCollection::quickHighlighters() const
 {
     return quickHighlighters_;