Merge pull request ppy#10779 from nanaya/mp-room-high-completed

Fix incorrect check for completed playlist item
venix12 · Dec 2, 2023 · 2d02394 · 2d02394
2 parents 568fb0a + 7c4a296
commit 2d02394
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/Models/Multiplayer/UserScoreAggregate.php b/app/Models/Multiplayer/UserScoreAggregate.php
@@ -202,7 +202,7 @@ public function userRank()
 
     private function updateUserTotal(ScoreLink $currentScoreLink, PlaylistItemUserHighScore $prev)
     {
-        if ($prev->exists) {
+        if ($prev->last_score_id !== null) {
             $this->total_score -= $prev->total_score;
             $this->accuracy -= $prev->accuracy;
             $this->pp -= $prev->pp;