fix: lint command is passive and throws errors #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@inverted-capital is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
inverted-capital
force-pushed
the
main
branch
from
ea52a5d to
d501248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the ghactions checks,
pnpm lintis run, but the issue is that this was running the fix option for biome, and so was not reporting any errors.This results in published code that causes our linters to complain, and so we fix the lint issues, but then when we want to merge upstream changes in, the lint errors are not fixed there, and so there is extra labour involved in resolving conflicts.