-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make ruby tests pass #53
base: PRODUCT-959/fun-add-ruby
Are you sure you want to change the base?
make ruby tests pass #53
Conversation
- change handler to conform to test expectation - change bootstrap.rb server address to use AWS_LAMBDA_RUNTIME_API from ENV
- add ruby2.5 and ruby2.7 runtimes - add install-ruby script - use rvm to install rubies - add ruby-version test for ruby2.7 and ruby2.7
hey @styfle - what's the best way to ask for a review / discuss this with you? I'm a little new to contributing so however you'd prefer I format my pull request, I'd be happy to do so. Additionally, I noticed that this is probably not going to work correctly end-to-end unless:
Please let me know your thoughts on the code! |
Ah, I see now about vercel/vercel#3667 - Would make sense to modify that PR a bit more to take my suggestions above into account? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🎉
I left a few comments.
- remove any mention of RuntimeLiteral type - change install-ruby.ts script to install rvm to a temp directory - adjust ruby-hello test to use JSON generation
…n find the ruby libraries
hey @styfle - thanks for the suggestions! I made the updates you recommended :) |
@@ -1,30 +1,8 @@ | |||
export type RuntimeLiteral = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to remove this though 🤔
AWS_LAMBDA_RUNTIME_API
from ENVLAMBDA_TASK_ROOT