Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore files are not included in pruned directory since 2.3.4 and this doesn't seem configurable #9789

Closed
1 task done
Artsu opened this issue Jan 24, 2025 · 3 comments · Fixed by #9797
Closed
1 task done
Labels
area: prune turbo prune

Comments

@Artsu
Copy link

Artsu commented Jan 24, 2025

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

Which canary version will you have in your reproduction?

2.3.4

Enviroment information


Expected behavior

Turbo 2.3.4 included this PR which makes turbo prune ignore all the files in .gitignore. While it is understandable why people might want this to happen, it should also be configurable which it doesn't seem to be or is not documented.

Actual behavior

Files in .gitignore are always filtered out in turbo prune and this cannot be turned off

To Reproduce

  1. Have a file ignored.txt in project package
  2. Add ignored.txt to .gitignore
  3. Run turbo prune
  4. ignored.txt is not included in the pruned output

Additional context

No response

@Artsu Artsu added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Jan 24, 2025
@eddieliccardo
Copy link

eddieliccardo commented Jan 24, 2025

Experienced a similar issue, .gitignore files that are explicitly included using ! are not included in the pruned output. Had to revert to 2.3.3.

@chris-olszewski chris-olszewski added area: prune turbo prune and removed kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Jan 24, 2025
@chris-olszewski
Copy link
Member

@eddieliccardo Can you open a new issue for that !pattern in .gitignore not being respected along with a reproduction repository?

@eddieliccardo
Copy link

@chris-olszewski Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: prune turbo prune
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants