Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prune): add --use-gitignore flag #9797

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

chris-olszewski
Copy link
Member

Description

Closes #9789

Adds a flag for opting out of respecting .gitignore. If you want to copy over files that are ignored by git you can now pass --use-gitignore=false to turbo prune.

Testing Instructions

Added unit tests. Quick manual test:

# A gitignored file in the app
[0 olszewski@chriss-mbp] /tmp/turborepo-gitignore-bug $ stat apps/web/.turbo       
16777234 160702923 drwxr-xr-x 6 olszewski wheel 0 192 "Jan 24 14:05:04 2025" "Jan 24 14:05:04 2025" "Jan 24 14:05:04 2025" "Jan 24 14:05:04 2025" 4096 0 0 .turbo
[0 olszewski@chriss-mbp] /tmp/turborepo-gitignore-bug $ turbo_dev --skip-infer prune web --use-gitignore=false
turbo 2.3.4

Generating pruned monorepo for web in /private/tmp/turborepo-gitignore-bug/out
 - Added @repo/eslint-config
 - Added @repo/typescript-config
 - Added @repo/ui
 - Added web
[0 olszewski@chriss-mbp] /tmp/turborepo-gitignore-bug $ stat out/apps/web/.turbo/                
16777234 160756779 drwxr-xr-x 3 olszewski wheel 0 96 "Jan 24 14:07:47 2025" "Jan 24 14:07:30 2025" "Jan 24 14:07:30 2025" "Jan 24 14:07:30 2025" 4096 0 0 out/apps/web/.turbo/
[0 olszewski@chriss-mbp] /tmp/turborepo-gitignore-bug $ rm -r out 
[0 olszewski@chriss-mbp] /tmp/turborepo-gitignore-bug $ turbo_dev --skip-infer prune web --use-gitignore      
turbo 2.3.4

Generating pruned monorepo for web in /private/tmp/turborepo-gitignore-bug/out
 - Added @repo/eslint-config
 - Added @repo/typescript-config
 - Added @repo/ui
 - Added web
[0 olszewski@chriss-mbp] /tmp/turborepo-gitignore-bug $ stat out/apps/web/.turbo/                       
stat: out/apps/web/.turbo/: stat: No such file or directory

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:16pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:16pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:16pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:16pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:16pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:16pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:16pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:16pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:16pm

@chris-olszewski chris-olszewski merged commit 878a22a into main Jan 24, 2025
40 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_gh_9789 branch January 24, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.gitignore files are not included in pruned directory since 2.3.4 and this doesn't seem configurable
2 participants