Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codemod): comment tmpdir for package managers #9534

Closed

Conversation

tomcastro
Copy link

Description

When using Yarn 4, the default is to use a local version to your repository. Codemod runs package managers from a tmp directory, which causes Yarn to think there's no local version and uses global version instead. This is fixed when removing the line to run from tmp dir, but needs to be tested if it works with other package managers/projects.

#8076

Testing Instructions

@tomcastro tomcastro requested a review from a team as a code owner November 28, 2024 12:28
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Nov 28, 2024
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:28am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:28am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:28am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:28am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:28am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:28am

Copy link

vercel bot commented Nov 28, 2024

@tomcastro is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@tomcastro tomcastro changed the title fix(codemod): Comment tmpdir for package managers fix(codemod): comment tmpdir for package managers Nov 28, 2024
@anthonyshew
Copy link
Contributor

Closing this one because I asked for it in conversation during 8076. I'm fairly confident we're on the right track now and we can toss this.

Really appreciate your help on the way to sorting this out. Thank you!

@anthonyshew anthonyshew closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants