Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(summary): no longer display non existent logfile #9907

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Feb 6, 2025

Description

Closes #9903

If caching is disabled, then we don't cache the task logs. We shouldn't display a path to a log file that doesn't exist.

Testing Instructions

Run a task that doesn't get cached with --summarize and make sure that logFile isn't present:

[0 olszewski@macbookpro] /tmp/summarize-colon-missing-logfile $ turbo_dev --skip-infer colon:command --summarize
turbo 2.4.1-canary.0

• Packages in scope: app-a, app-b, pkg-a, pkg-b, tooling-config
• Running colon:command in 5 packages
• Remote caching disabled
pkg-a:colon:command: cache bypass, force executing 71e88464fc594d21
pkg-a:colon:command: 
pkg-a:colon:command: 
pkg-a:colon:command: > colon:command
pkg-a:colon:command: > echo "Colon command!"
pkg-a:colon:command: 
Colon command!


  Tasks:    1 successful, 1 total
 Cached:    0 cached, 1 total
   Time:    230ms 
Summary:    /private/tmp/summarize-colon-missing-logfile/.turbo/runs/2sfbsk4LTfEuhw4VWPU60jJMmdi.json

[0 olszewski@macbookpro] /tmp/summarize-colon-missing-logfile $ rg -F 'logFile' .turbo/runs/2sfbsk4LTfEuhw4VWPU60jJMmdi.json
[1 olszewski@macbookpro] /tmp/summarize-colon-missing-logfile $ 

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:14pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:14pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:14pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:14pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:14pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:14pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:14pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:14pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:14pm

@chris-olszewski chris-olszewski merged commit df21d74 into main Feb 6, 2025
40 checks passed
@chris-olszewski chris-olszewski deleted the chrisolszewski/turbo-4439-summary-task-log-file-missing-for-commands-with-colon branch February 6, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary task log file missing for commands with colon character
2 participants