chore(release): remove goreleaser #9918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
force-pushed
the
olszewski/chore_remove_goreleaser
branch
from
47c89f2 to
10ea8a6
Compare
tknickman
approved these changes
Feb 7, 2025
chris-olszewski
added a commit
that referenced
this pull request
Feb 10, 2025
### Description Third try is the charm. See #9905 and #9909 for details. Additional changes: - Make sure `turbo` binaries are marked as executable. Since they get downloaded via `@actions/download-artifact` which strips permissions: [docs](https://github.com/actions/download-artifact?tab=readme-ov-file#permission-loss) - Correctly set `os: ["win32"]` for the windows package for `turbo-windows-${arch}` ### Testing Instructions Changes from previous PRs: added an e2e test to make sure that the tarball is installable and the included executable is just that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Third try is the charm. See #9905 and #9909 for details.
Additional changes:
turbobinaries are marked as executable. Since they get downloaded via@actions/download-artifactwhich strips permissions: docsos: ["win32"]for the windows package forturbo-windows-${arch}Testing Instructions
Changes from previous PRs: added an e2e test to make sure that the tarball is installable and the included executable is just that.