Make the npm package installation idempotent

[dickp]

Installing the 'latest' package triggers a change every time puppet agent runs. This changes the default to 'present' so it installs the latest at the time of installation, and lets the admin choose to upgrade to subsequent versions at a time of their choosing.

It also fixes the home_dir setting, so a doubled .npm directory isn't created.

[juanpicado]

@dickp but that means present tag should be present? how the users would be aware of it?

[dickp]

The difference between 'latest' and 'present' is that 'latest' will check for updates every time puppet runs, while 'present' only makes sure the package is installed - and if it isn't it installs the latest at that time, and if it is installed it does nothing.

The problem with 'latest' is that it registers a change every time.

[troy2914]

@dickp but that means present tag should be present? how the users would be aware of it?

Instead of
$version = undef,
in the declaration
Variant[Enum['present', 'absent', 'held', 'installed', 'latest'], Pattern[/./]] $version = 'present',

That way it is explicit as what that field expects and will allow. And also means the inline if can be removed
so it's just
$npm_ensure = $version

[troy2914]

@dickp but that means present tag should be present? how the users would be aware of it?

Instead of $version = undef, in the declaration Variant[Enum['present', 'absent', 'held', 'installed', 'latest'], Pattern[/./]] $version = 'present',

That way it is explicit as what that field expects and will allow. And also means the inline if can be removed so it's just $npm_ensure = $version

btw, the same thing should be done with $ldap_plugin_version, also @param doc should be added for those two variables.