Skip to content

Commit

Permalink
Force TypeScript usage of NPM events dep instead of Node built-in `…
Browse files Browse the repository at this point in the history
…events` module

### Details

- Generated TS types should not depend on Node types.
- So let's force module resolution to take and read `events` from the NPM **events** module.
  • Loading branch information
ibc committed Jun 10, 2024
1 parent b4ac820 commit 97137d0
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 29 deletions.
53 changes: 29 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@types/debug": "^4.1.12",
"awaitqueue": "^3.0.2",
"debug": "^4.3.5",
"events": "^3.3.0",
"npm-events-package": "npm:events@^3.3.0",
"fake-mediastreamtrack": "^1.2.0",
"h264-profile-level-id": "^2.0.0",
"queue-microtask": "^1.2.3",
Expand All @@ -76,7 +76,7 @@
"ua-parser-js": "^1.0.38"
},
"devDependencies": {
"@types/events": "^3.0.3",
"@types/npm-events-package": "npm:@types/events@^3.0.3",
"@types/jest": "^29.5.12",
"@types/node": "20",
"@types/sdp-transform": "^2.4.9",
Expand Down
6 changes: 3 additions & 3 deletions src/EnhancedEventEmitter.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { EventEmitter } from 'events';
import { EventEmitter, Listener } from 'npm-events-package';
import { Logger } from './Logger';

const logger = new Logger('EnhancedEventEmitter');
Expand Down Expand Up @@ -109,11 +109,11 @@ export class EnhancedEventEmitter<
return super.listenerCount(eventName);
}

listeners<K extends keyof E & string>(eventName: K): Function[] {
listeners<K extends keyof E & string>(eventName: K): Listener[] {
return super.listeners(eventName);
}

rawListeners<K extends keyof E & string>(eventName: K): Function[] {
rawListeners<K extends keyof E & string>(eventName: K): Listener[] {
return super.rawListeners(eventName);
}
}

0 comments on commit 97137d0

Please sign in to comment.