adds a .tool-versions file #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcdavid
reviewed
Dec 13, 2019
.tool-versions
Outdated
| @@ -0,0 +1 @@ | |||
| nodejs 12.13.0 | |||
There was a problem hiding this comment.
Do we want to use this version of nodejs or the latest version (13.3.0)?
There was a problem hiding this comment.
Overall I approve of this though so whatever version gets picked has my approval.
There was a problem hiding this comment.
Good point, @samcdavid . I'll change this to 13.3.
samcdavid
approved these changes
Dec 13, 2019
--- - Very uses asdf as it's version management tool, so a .tool-versions file would be helpful for getting a new user up and running quickly. - The version of node specified is not the latest version. How --- - Changes node version to 13.3.0 in tool versions file Side effects ------------ -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be helpful to have this .tool-versions file since we're using asdf for version management so that new users could get up and running more quickly. I'm open to suggestions for whatever other additions should be made to the file