Address some comments on readability

verypossible · Oct 7, 2020 · 8787d31 · 8787d31
1 parent 18c6b5e
commit 8787d31
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/scrub.ex b/lib/scrub.ex
@@ -63,7 +63,7 @@ defmodule Scrub do
       {:ok, _} ->
         {:error, :no_tag_found}
 
-      error ->
+      {:error, _} = error ->
         error
     end
   end

diff --git a/lib/scrub/cip/connection_manager.ex b/lib/scrub/cip/connection_manager.ex
@@ -139,9 +139,8 @@ defmodule Scrub.CIP.ConnectionManager do
       end
 
     request_path_padded = <<request_path::binary, 0x00::size(request_path_padding)-unit(8)>>
-    request_path = <<0x91, byte_size(request_path)::usint, request_path_padded::binary>>
 
-    <<request_path::binary>>
+    <<0x91, byte_size(request_path)::usint, request_path_padded::binary>>
   end
 
   def encode_request_path(request_path) when is_list(request_path) do