-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docstrings (numPy style) to methods in utils #35
Open
lena-kuhn
wants to merge
1
commit into
vgrabovets:master
Choose a base branch
from
lena-kuhn:feat/add_docstrings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,20 @@ | |
|
||
|
||
def detect_language(text, proba_threshold): | ||
"""Detect language code and probability of input text based on 'cld2'. | ||
|
||
Parameters | ||
---------- | ||
text : utf8Bytes | ||
Text to detect language as unicode. | ||
proba_threshold : float | ||
Minimum probability cld2 language detection has to output in order to accept proposed language code. | ||
|
||
Returns | ||
------- | ||
str | ||
Language code detected by cld2. | ||
""" | ||
_, _, details = cld2.detect(text) | ||
|
||
language_code = details[0].language_code | ||
|
@@ -20,11 +34,35 @@ def detect_language(text, proba_threshold): | |
return language_code | ||
|
||
|
||
def keep_only_letters(string): | ||
return ' '.join(token.group() for token in LETTERS_RE.finditer(string)) | ||
def keep_only_letters(text): | ||
"""Apply regex to only keep letters. | ||
|
||
Parameters | ||
---------- | ||
text : str | ||
Text to search for letters in. | ||
|
||
Returns | ||
------- | ||
str | ||
Input text cleaned by regex to only contain letters. | ||
""" | ||
return ' '.join(token.group() for token in LETTERS_RE.finditer(text)) | ||
|
||
|
||
def separate_words(text): | ||
"""Seperate text to tokens by whitespace and dimiss numeric tokens. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typos: |
||
|
||
Parameters | ||
---------- | ||
text : str | ||
Text to tokenize. | ||
|
||
Returns | ||
------- | ||
list of str | ||
Tokenized text. | ||
""" | ||
words = [] | ||
|
||
for word in text.split(): | ||
|
@@ -35,5 +73,17 @@ def separate_words(text): | |
|
||
|
||
def split_sentences(text): | ||
"""Split text into sentences with custom regex boundaries. | ||
|
||
Parameters | ||
---------- | ||
text : str | ||
Text to split on sentence delimiters. | ||
|
||
Returns | ||
------- | ||
list of str | ||
Text split into sentences. | ||
""" | ||
sentences = SENTENCE_DELIMITERS_RE.split(text) | ||
return sentences |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
str
, shouldn't it?